[PATCH] D85778: More accurately compute the ranges of possible values for +, -, *, &, %.
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 1 17:42:44 PDT 2020
rsmith added a comment.
In D85778#2248714 <https://reviews.llvm.org/D85778#2248714>, @nikic wrote:
> Just for the record, the additional analysis has a measurable compile-time impact (0.3% at O0): https://llvm-compile-time-tracker.com/compare.php?from=e7f53044e7263cdbbb4fed9abf086b88ba486bba&to=cff6dda604cb0548bef5e5951dd1e74536110588&stat=instructions
Thanks, it seems very likely that this is caused by `CheckImplicitConversion` now calling `CheckExprRange` twice. It looks like that's not only avoidable, but there's a (pre-existing) bug here that we can squash at the same time :) Should be fixed in rG0ffbbce78de60f4f4d03d6ef97fe2f3bb4275e08 <https://reviews.llvm.org/rG0ffbbce78de60f4f4d03d6ef97fe2f3bb4275e08>.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85778/new/
https://reviews.llvm.org/D85778
More information about the cfe-commits
mailing list