[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added inline comments.


================
Comment at: clang/include/clang/Basic/Builtins.def:488
+BUILTIN(__builtin_calloc, "v*zz", "F")
+BUILTIN(__builtin_exit, "vi", "Fr")
 BUILTIN(__builtin_fprintf, "iP*cC*.", "Fp:1:")
----------------
aaron.ballman wrote:
> Should we be adding `atexit()` as well?
GCC doesn't have a `__builtin_atexit`, so we'd need some reason to invent one.


================
Comment at: clang/include/clang/Basic/Builtins.def:513
 BUILTIN(__builtin_printf, "icC*.", "Fp:0:")
+BUILTIN(__builtin_putchar, "ii", "F")
+BUILTIN(__builtin_puts, "icC*", "nF")
----------------
aaron.ballman wrote:
> Should we also add a builtin for `putc()` (I know that's often a macro, so I'm not certain if it applies)?
Yes, GCC has a `__builtin_putc`, so it'd make sense for us to support that too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86508/new/

https://reviews.llvm.org/D86508