[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 1 13:01:21 PDT 2020
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
Sorry for not noticing this review earlier.
We can't make this change. Module map files are still useful and still used even when modules are disabled -- they power the undeclared inclusion and private header diagnostics, and with `-fmodules-local-submodule-visibility` you still get modular semantics for modular headers even when `-fmodules` is disabled.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86802/new/
https://reviews.llvm.org/D86802
More information about the cfe-commits
mailing list