[PATCH] D86841: [clang] Add noprogress attribute deduction for infinite loops

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 31 06:25:00 PDT 2020


aaron.ballman added inline comments.


================
Comment at: clang/lib/CodeGen/CGLoopInfo.h:211
             llvm::ArrayRef<const Attr *> Attrs, const llvm::DebugLoc &StartLoc,
-            const llvm::DebugLoc &EndLoc);
+            const llvm::DebugLoc &EndLoc, const bool NoProgress = false);
 
----------------
I'd drop the top-level `const` on the declaration of `NoProgress` (that's not a style we typically use in the project).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86841/new/

https://reviews.llvm.org/D86841



More information about the cfe-commits mailing list