[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

[Raul Tambre via Phabricator via cfe-commits]

tambre added inline comments.


================
Comment at: clang/include/clang/Basic/IdentifierTable.h:231
     return ObjCOrBuiltinID == tok::NUM_OBJC_KEYWORDS;
   }
 
----------------
rjmccall wrote:
> Do we need to support reverting builtins anymore?
We don't. It'd be possible to set the builtin ID of identifiers to `0` as an optimization to avoid declaration compatibility checking if there's a declaration that would hide the actual builtin. But I doubt it's worth it.

I've removed code related to this, as nothing was actually checking the reverted status anymore.


================
Comment at: clang/test/CodeGen/callback_pthread_create.c:3
+// RUN: false
+// XFAIL: *
+
----------------
rjmccall wrote:
> I guess the problem with pthread_create is that the types are not really reasonable to synthesize.  I wonder if we can use an approach more like what we do with C++, where we don't magically synthesize a declaration but where we do recognize that a particular declaration is compatible with the builtin signature.
Seems like a good idea. Would also reduce code duplication between C and C++. I would be willing to look into that as a followup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77491/new/

https://reviews.llvm.org/D77491