[PATCH] D67113: ICK_Function_Conversion is a third kind conversion

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 28 07:37:17 PDT 2020


aaron.ballman added a comment.

In D67113#2243451 <https://reviews.llvm.org/D67113#2243451>, @aaronpuchert wrote:

> Maybe this is to trivial for a review. The comment on `StandardConversionSequence::Third` in clang/Sema/Overload.h says
>
>> The third conversion can be a qualification conversion or a function conversion.

There may be a deeper issue here in that there are four standard conversion sequences, not three: http://eel.is/c++draft/conv#1, but otherwise this change seems correct to me (function conversion is certainly not in the first group).

Do you have a test case which can exercise this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67113/new/

https://reviews.llvm.org/D67113



More information about the cfe-commits mailing list