[PATCH] D85031: [builtins] Unify the softfloat division implementation
Anatoly Trosinenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 28 07:01:21 PDT 2020
atrosinenko updated this revision to Diff 288599.
atrosinenko added a comment.
This update is expected to be completely NFC w.r.t. code behavior and significantly clarify the proof up to the end of half-width iterations.
Particularly, the reasoning about possible overflow of intermediate results turned out to be actually unclear/incorrect.
@sepavloff could you take a look on the new version in case it clarifies some of your questions? Another update for the second half of function may follow slightly later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85031/new/
https://reviews.llvm.org/D85031
Files:
compiler-rt/lib/builtins/divdf3.c
compiler-rt/lib/builtins/divsf3.c
compiler-rt/lib/builtins/divtf3.c
compiler-rt/lib/builtins/fp_div_impl.inc
compiler-rt/lib/builtins/fp_lib.h
compiler-rt/lib/builtins/int_util.h
compiler-rt/test/builtins/Unit/divdf3_test.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85031.288599.patch
Type: text/x-patch
Size: 43482 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200828/396f5f3b/attachment-0001.bin>
More information about the cfe-commits
mailing list