[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

[Eduardo Caldas via Phabricator via cfe-commits]

eduucaldas marked an inline comment as done.
eduucaldas added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:245
+///     `int S::f(){}` -> range of `S::f()`.
+/// FIXME: \p Name must be a source range, e.g. for `operator+`.
 static SourceRange getDeclaratorRange(const SourceManager &SM, TypeLoc T,
----------------
gribozavr2 wrote:
> eduucaldas wrote:
> > There was no problem with the declarator of `operator+` should I remove this?
> > Also I really tried to break it ^^.
> > 
> > I think though perhaps this is going to bite us in an obscure way, so I would just remove the `e.g. ...`.
> Feel free to remove the fixme.
> 
> What do you mean by "remove the e.g. ..."? Removing the examples from the comment? Why?
I meant 
```
/// FIXME: \p Name must be a source range, e.g. for `operator+`.
```
->
```
/// FIXME: \p Name must be a source range.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86719/new/

https://reviews.llvm.org/D86719