[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class
Dmitri Gribenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 27 11:53:28 PDT 2020
gribozavr2 accepted this revision.
gribozavr2 added a comment.
This revision is now accepted and ready to land.
> Perhaps we should inline getQualifiedNameStart and getInitializerRange and make getDeclaratorRange a member function taking a Decl. What do you think?
These helpers seem to have well-defined semantics, so I'd rather keep them separate. If anything, I'd make helpers into free functions to emphasize that they don't use the class member variables and are standalone functions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86719/new/
https://reviews.llvm.org/D86719
More information about the cfe-commits
mailing list