[PATCH] D86711: [clang-format] Parse __attribute((foo)) as a pointer qualifier

Alexander Richardson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 27 08:48:29 PDT 2020


arichardson added inline comments.


================
Comment at: clang/lib/Format/TokenAnnotator.cpp:1895
                            tok::kw_restrict, tok::kw_volatile,
-                           tok::kw_noexcept) ||
+                           tok::kw___attribute, tok::kw_noexcept) ||
         (NextToken->is(tok::l_brace) && !NextToken->getNextNonComment()))
----------------
arichardson wrote:
> aaron.ballman wrote:
> > What about other attributes than GNU-style ones, like `[[clang::address_space(0)]]`?
> I guess those should also be handled. I can try to do that in a follow-up change.
It appears that they are already handled for this case. I've handled them in cast expressions in D86721. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86711/new/

https://reviews.llvm.org/D86711



More information about the cfe-commits mailing list