[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

Please fix Clang-tidy warnings and mention changes in Release Notes.



================
Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:317
+  if (Style.Case == IdentifierNamingCheck::CaseType::CT_HungarianNotation) {
+    const auto TypePrefix = getHungarianNotationTypePrefix(Type.str(), Decl);
+    if (TypePrefix.length() > 0) {
----------------
Please don't use auto when type is not specified explicitly in same statement or iterator.


================
Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:430
+    const NamedDecl *pNamedDecl = dyn_cast<NamedDecl>(pDecl);
+    const auto TypePrefix =
+        getHungarianNotationTypePrefix(Type.str(), pNamedDecl);
----------------
Please don't use auto when type is not specified explicitly in same statement or iterator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86671/new/

https://reviews.llvm.org/D86671