[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

[Teresa Johnson via Phabricator via cfe-commits]

tejohnson added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HeapProfiler.cpp:563
+    return false;
+  if (!ClDebugFunc.empty() && ClDebugFunc == F.getName())
+    return false;
----------------
MaskRay wrote:
> `ClDebugFunc != F.getName()`
Your suggestion doesn't work as that reverses the handling. But in any case, the empty check seems unnecessary (that was cloned from the asan code), so I've removed that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85948/new/

https://reviews.llvm.org/D85948