[PATCH] D86624: [clang] Exclude invalid destructors from lookups.

Adam Czachorowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 26 08:18:40 PDT 2020


adamcz added inline comments.


================
Comment at: clang/test/PCH/cxx-invalid-destructor.cpp:2
+// RUN: %clang_cc1 -x c++ -std=c++11 -emit-pch -o %t %S/cxx-invalid-destructor.h -fallow-pch-with-compiler-errors
+// RUN: %clang_cc1 -x c++ -std=c++11 -include-pch %t %S/cxx-invalid-destructor.cpp -fsyntax-only -fno-validate-pch
+
----------------
sammccall wrote:
> nit: -fno-validate-pch shouldn't be needed IIUC
We need this, otherwise the PCH file is rejected for containing errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86624/new/

https://reviews.llvm.org/D86624



More information about the cfe-commits mailing list