[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

Alexandre Ganea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 26 06:19:53 PDT 2020


aganea added inline comments.


================
Comment at: clang/tools/driver/driver.cpp:537
+      // When running in integrated-cc1 mode, the CrashRecoveryContext returns
+      // the same code as if the program crashed. On Unix, that is codes >128.
+      IsCrash |= CommandRes > 128;
----------------
MaskRay wrote:
> (From a non-native speaker)
> 
> "that is codes >128" Should the singular form be used?
Rephrased.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70378/new/

https://reviews.llvm.org/D70378



More information about the cfe-commits mailing list