[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 25 11:31:00 PDT 2020


tejohnson added inline comments.


================
Comment at: llvm/lib/Analysis/OptimizationRemarkEmitter.cpp:103
     BFI = &getAnalysis<LazyBlockFrequencyInfoPass>().getBFI();
-  else
+    // Get hotness threshold from PSI. This should only happen once.
+    if (Context.isDiagnosticsHotnessThresholdSetFromPSI()) {
----------------
Can you clarify what you mean by this only happening once?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85808/new/

https://reviews.llvm.org/D85808



More information about the cfe-commits mailing list