[PATCH] D85810: [clang] Pass-through remarks options to linker

[Teresa Johnson via Phabricator via cfe-commits]

tejohnson added a comment.

Looks pretty good but I think it can be simplified in one place as I note below.



================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:596
+  // Handle remark diagnostics on screen options: '-Rpass-*'.
+  if (usesRpassOptions(Args))
+    renderRpassOptions(Args, CmdArgs);
----------------
Is this guard needed? It looks like renderRpassOptions will do the right thing if none are specified (won't add anything). Right now you end up checking each one a second time if any are enabled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85810/new/

https://reviews.llvm.org/D85810