[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

[Zachary Henkel via Phabricator via cfe-commits]

zahen marked an inline comment as done.
zahen added a comment.

In D85998#2236401 <https://reviews.llvm.org/D85998#2236401>, @hans wrote:

> I'm still curious why it seems it's not looking for link.exe in the /fake dir though.

clang\lib\Driver\ToolChains\MSVC.cpp:311

FindVisualStudioExecutable 
FilePath = /fake\bin\Hostx64\x64\link.exe 
The test llvm::sys::fs::can_execute(FilePath) fails and the function returns "link.exe".  This isn't seen in our environment because //absent path// probes are always allowed, it's only //actual file reads// that need to be tracked.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85998/new/

https://reviews.llvm.org/D85998