[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus marked an inline comment as done and an inline comment as not done.
Szelethus added a comment.

I'll get the nits I didn't object to fixed, thats the status you're looking for :)



================
Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:1338-1339
 void TokenPrinter::printToken(const Token &Tok) {
+  // TODO: Handle the case where hash and hashhash occurs right before
+  // __VA_ARGS__.
+
----------------
steakhal wrote:
> Szelethus wrote:
> > steakhal wrote:
> > > What does //hashhash// mean? I might lack some context though :D
> > `#` and `##` respectively. The test cases you pointed out as flawed refer to this FIXME, though a FIXME in the tests themselves wouldn't hurt.
> Maybe `HashtagHashtag`?
> Or an example would be even better like: `##__VA_ARGS__`
If you look a few lines down, you can see that its not up to us to choose this one :^) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86135/new/

https://reviews.llvm.org/D86135