[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.
David Blaikie via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 24 17:04:27 PDT 2020
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Thanks for testing/catching this (what sort of testing have you been doing that discovered this?)!
& yeah, the way shouldOmitDefinition is now written (with this fix) is right - that every check only gives an opportunity to return true, then falls through to the next case - never an early return false.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86491/new/
https://reviews.llvm.org/D86491
More information about the cfe-commits
mailing list