[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

Serge Pavlov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 24 09:30:52 PDT 2020


sepavloff added a comment.

In D85960#2218798 <https://reviews.llvm.org/D85960#2218798>, @kpn wrote:

> You mentioned in D85920 <https://reviews.llvm.org/D85920> a need to merge this review with that review. I don't think that's needed. This code here is farther along. It does everything that D85920 <https://reviews.llvm.org/D85920> does and has necessary pieces implemented as well.

I think you are right. I looked through D85920 <https://reviews.llvm.org/D85920>, in essence it does the same changes as this patch. And this patch has better support of serialization and some tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85960/new/

https://reviews.llvm.org/D85960



More information about the cfe-commits mailing list