[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 24 08:28:16 PDT 2020


nridge added inline comments.


================
Comment at: clang/lib/Index/IndexTypeSourceInfo.cpp:167
+    if (!TraverseTemplateName(TL.getTypePtr()->getTemplateName()))
+      return false;
+
----------------
hokein wrote:
> nit: this could be simplified by calling the `base::TraverseTemplateSpecializationTypeLoc`
I don't see how, given that `WalkUpFromTemplateSpecializationTypeLoc()`needs to be called with `Relations` containing `RelationIsBaseOf`, while `TraverseTemplateArgumentLoc()` needs to be called with `Relations` empty.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86424/new/

https://reviews.llvm.org/D86424



More information about the cfe-commits mailing list