[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 24 05:40:26 PDT 2020


steakhal added a comment.

In D86295#2233244 <https://reviews.llvm.org/D86295#2233244>, @vsavchenko wrote:

> Here is a short summary how to do regression testing (check that all warnings are the same):

Oh thanks for the detailed guide, I will make the experiment.

However the `./SATest.py docker --build-image` seems broken.

  E: Version '9.0.1-2.3~ubuntu1.18.04.1' for 'python3-pip' was not found
  The command '/bin/sh -c apt-get update && apt-get install -y     git=1:2.17.1-1ubuntu0.7     gettext=0.19.8.1-6ubuntu0.3     python3=3.6.7-1~18.04     python3-pip=9.0.1-2.3~ubuntu1.18.04.1     cmake=3.17.3-0kitware1     ninja-build=1.8.2-1' returned a non-zero code: 100

In the DockerFile it should be `python3-pip=9.0.1-2.3~ubuntu1.18.04.2` instead.
Shouldn't we anchor it to a specific version of //bionic// in the `FROM` clause?

In D86295#2233248 <https://reviews.llvm.org/D86295#2233248>, @Szelethus wrote:

> I really like the patch, but have nothing to add to what other reviewers already said. Nice!

Thanks:)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86295/new/

https://reviews.llvm.org/D86295



More information about the cfe-commits mailing list