[PATCH] D86289: [NFC][compiler-rt] Factor out __mulo[sdt]i3 implementations to .inc file

Anatoly Trosinenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 20 07:13:26 PDT 2020


atrosinenko created this revision.
atrosinenko added reviewers: MaskRay, kamleshbhalui, luismarques, efriedma, aykevl.
Herald added subscribers: Sanitizers, dberris.
Herald added a project: Sanitizers.
atrosinenko requested review of this revision.

The existing implementations are almost identical except for width of the integer type.

Factor them out to int_mulo_impl.inc for better maintainability.

The following command may help understanding the changes:

  diff int_mulo_impl.inc \
       <(git show master:./mulosi4.c | sed 's/si_int/fixint_t/g')

The `si` and `di` variants has three lines different (with two of them being comments) and `ti` has a bit larger diff.

Note: this patch is almost identical to D86277: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file <https://reviews.llvm.org/D86277>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86289

Files:
  compiler-rt/lib/builtins/int_mulo_impl.inc
  compiler-rt/lib/builtins/mulodi4.c
  compiler-rt/lib/builtins/mulosi4.c
  compiler-rt/lib/builtins/muloti4.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86289.286810.patch
Type: text/x-patch
Size: 5511 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200820/593b102e/attachment-0001.bin>


More information about the cfe-commits mailing list