[PATCH] D86277: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file
Anatoly Trosinenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 20 03:36:49 PDT 2020
atrosinenko created this revision.
atrosinenko added reviewers: MaskRay, kamleshbhalui, luismarques, efriedma, aykevl.
Herald added subscribers: Sanitizers, dberris.
Herald added a project: Sanitizers.
atrosinenko requested review of this revision.
The existing implementations are almost identical except for width of the integer type.
Factor them out to int_mulv_impl.inc for better maintainability.
The following command may help understanding the changes:
diff int_mulv_impl.inc \
<(git show master:./mulvsi3.c | sed 's/si_int/fixint_t/g')
The `si` and `di` variants has three lines different (with two of them being comments) and `ti` has a bit larger diff.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D86277
Files:
compiler-rt/lib/builtins/int_mulv_impl.inc
compiler-rt/lib/builtins/mulvdi3.c
compiler-rt/lib/builtins/mulvsi3.c
compiler-rt/lib/builtins/mulvti3.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86277.286764.patch
Type: text/x-patch
Size: 5360 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200820/fbcb3a51/attachment.bin>
More information about the cfe-commits
mailing list