[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build
Balázs Benics via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 19 15:49:04 PDT 2020
steakhal added a comment.
In D86223#2226876 <https://reviews.llvm.org/D86223#2226876>, @xazax.hun wrote:
> Exactly, but you could return a StringRef to static storage.
>
> I am fine with both approach. Whichever you find cleaner.
Eh, I'm not sure if it worth it to put these into virtual functions - as conditionally overriding functions is not really a good idea.
So we would not win much.
I still think that this way is the cleanest AFAIK.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86223/new/
https://reviews.llvm.org/D86223
More information about the cfe-commits
mailing list