[PATCH] D86069: [clang] When loading preamble from AST file, re-export modules in Sema.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 19 04:27:40 PDT 2020
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Sorry, I was just not reading the test clearly. LGTM
================
Comment at: clang/lib/Serialization/ASTReader.cpp:4990
PP.makeModuleVisible(Imported, Import.ImportLoc);
- // FIXME: should we tell Sema to make the module visible too?
}
----------------
maybe replace this with a comment pointing at UpdateSema() for the sema part
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86069/new/
https://reviews.llvm.org/D86069
More information about the cfe-commits
mailing list