[clang] b32f203 - [X86][Driver] Remove code that forced a core2 mtune from MachO::TranslateArgs.

Craig Topper via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 18 23:45:29 PDT 2020


Author: Craig Topper
Date: 2020-08-18T23:44:36-07:00
New Revision: b32f203edc8579d4c0023007880293c3f9404fb7

URL: https://github.com/llvm/llvm-project/commit/b32f203edc8579d4c0023007880293c3f9404fb7
DIFF: https://github.com/llvm/llvm-project/commit/b32f203edc8579d4c0023007880293c3f9404fb7.diff

LOG: [X86][Driver] Remove code that forced a core2 mtune from MachO::TranslateArgs.

mtune was previously ignored by the compiler so I'm not sure this
did anything. But after D85384 we're starting to support mtune
and this code is now causing a couple test failures on MacOS.

Added: 
    

Modified: 
    clang/lib/Driver/ToolChains/Darwin.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Driver/ToolChains/Darwin.cpp b/clang/lib/Driver/ToolChains/Darwin.cpp
index cf8a3e6aee27..04349ff6af98 100644
--- a/clang/lib/Driver/ToolChains/Darwin.cpp
+++ b/clang/lib/Driver/ToolChains/Darwin.cpp
@@ -2271,11 +2271,6 @@ DerivedArgList *MachO::TranslateArgs(const DerivedArgList &Args,
     }
   }
 
-  if (getTriple().isX86())
-    if (!Args.hasArgNoClaim(options::OPT_mtune_EQ))
-      DAL->AddJoinedArg(nullptr, Opts.getOption(options::OPT_mtune_EQ),
-                        "core2");
-
   // Add the arch options based on the particular spelling of -arch, to match
   // how the driver driver works.
   if (!BoundArch.empty()) {


        


More information about the cfe-commits mailing list