[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys
Adrian Prantl via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 18 13:41:11 PDT 2020
aprantl added inline comments.
================
Comment at: clang/include/clang/Serialization/ModuleManager.h:62
+ struct EntryKey {
+ const FileEntry *Entry;
----------------
aprantl wrote:
> Can you add a doxygen comment explaining why we compute our own hashing as opposed to using the FileEntry pointer?
Basically what you wrote in the description of the review...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85981/new/
https://reviews.llvm.org/D85981
More information about the cfe-commits
mailing list