[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

Robert Widmann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 18 10:19:39 PDT 2020


CodaFi added a comment.

Switched tactics here. Rather than just change the source of the entropy, let's increase it from just inodes to (64-bits of inode) plus (file size) plus (mod time). It is still possible to defeat this scheme, but it means an attacker would have to replace the PCM with one that has been padded out to the same size then backdate its modtime to match the one in the cache - or some cascading failure of the syscalls providing these data conspires to make this happen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85981/new/

https://reviews.llvm.org/D85981



More information about the cfe-commits mailing list