[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

Abhina Sree via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 17 11:16:59 PDT 2020


abhina.sreeskantharajan marked an inline comment as done.
abhina.sreeskantharajan added inline comments.


================
Comment at: clang/test/Preprocessor/init.c:1041
 //
+// RUN: %clang_cc1 -E -dM -ffreestanding -triple=s390x-none-zos -fno-signed-char < /dev/null | FileCheck -match-full-lines -check-prefix S390X-ZOS %s
+// RUN: %clang_cc1 -x c -E -dM -ffreestanding -triple=s390x-none-zos -fno-signed-char < /dev/null | FileCheck -match-full-lines -check-prefix S390X-ZOS -check-prefix S390X-ZOS-C %s
----------------
MaskRay wrote:
> The file has been split. You'll want to add new tests to `init-zos.c` or the like.
> 
> Not sure it is important to run so many invocations of clang_cc1. Can you pick some essential ones? The many invocations make the test slow.
Thanks for the suggestion. I created a new file and reduced the number of invocations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85324/new/

https://reviews.llvm.org/D85324



More information about the cfe-commits mailing list