[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 17 00:46:43 PDT 2020
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks!
================
Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1781
+ if (const auto *TC = D->getTypeConstraint()) {
+ Expr *IDC = TC->getImmediatelyDeclaredConstraint();
+ TRY_TO(TraverseStmt(IDC));
----------------
nit: just
```
if (Expr *IDC = ...) {
...
} else {
TRY_TO(TraverseConceptReference(*TC));
}
```
================
Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Concept.cpp:2
+//===- unittest/Tooling/RecursiveASTVisitorTests/Concept.cpp
+//----------------===//
+//
----------------
nit: should be merged in the above line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84136/new/
https://reviews.llvm.org/D84136
More information about the cfe-commits
mailing list