[PATCH] D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:289
+  for (QualType CastToTy: CastToTyVec) {
+    if (CastFromTy->isPointerType())
+      CastToTy = C.getASTContext().getPointerType(CastToTy);
----------------
whisperity wrote:
> NoQ wrote:
> > Hmm, is this phabricator's way of displaying tabs?
> I believe it is not displaying tabs, but rather just indicating that the current line changed in a way that //only// the indentation has changed... instead of marking the old side of the diff red. The HTML element is `span.depth-in`. A `span.depth-out` is red, and the arrow points the other way.
> 
> But I agree this is a new thing since the version update.
Aha, ok, nice!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85728/new/

https://reviews.llvm.org/D85728