[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

Zachary Henkel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 15 14:34:26 PDT 2020


zahen added a comment.

Once accepted, someone else will need to submit on my behalf.



================
Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:74
+   if (Arg *A = Args.getLastArg(options::OPT__SLASH_vctoolsdir)) {
+    Path = A->getValue();
+    VSLayout = MSVCToolChain::ToolsetLayout::VS2017OrNewer;
----------------
Deliberately not validating the input.  The primary motivation is to prevent unnecessary file and registry access.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85998/new/

https://reviews.llvm.org/D85998



More information about the cfe-commits mailing list