[PATCH] D86020: [MemCpyOptimizer] Optimize passing byref function arguments down the stack

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 15 13:30:25 PDT 2020


jdoerfert added a comment.

This needs an LLVM IR test.



================
Comment at: llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp:1332
+          if (CB->isByValArgument(i) || CB->paramHasAttr(i, Attribute::ByRef))
+            MadeChange |= processByValOrByRefArgument(*CB, i);
       }
----------------
I thought we have a shortcut to check for both attributes. If not, we might want one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86020/new/

https://reviews.llvm.org/D86020



More information about the cfe-commits mailing list