[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

[David Li via Phabricator via cfe-commits]

davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

lgtm. The user option should be documented after the runtime is ready.



================
Comment at: llvm/lib/Transforms/Instrumentation/HeapProfiler.cpp:71
+
+// This flag may need to be replaced with -f[no-]heapprof-reads.
+static cl::opt<bool> ClInstrumentReads("heapprof-instrument-reads",
----------------
-f[no-]memprof-reads?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85948/new/

https://reviews.llvm.org/D85948