[PATCH] D85144: [clang] Improve Dumping of APValues

[Tyker via Phabricator via cfe-commits]

Tyker updated this revision to Diff 285747.
Tyker added a comment.

In D85144#2205461 <https://reviews.llvm.org/D85144#2205461>, @riccibruno wrote:

> I agree with you that it's fine to use `printPretty`  for leaves (and additionally it would be annoying to duplicate the `LValue` case); that's what I was planning to do anyway.
>
> What I am not sure I agree with is the additional complexity to handle the (debugger-only and easy to avoid) case where no context is given.

i don't have a strong opinion on this.
it adds complexity, isn't testable and in many situation where the ASTContext is missing the QualType is missing too anyway.
soo i removed that code path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85144/new/

https://reviews.llvm.org/D85144

Files:
  clang/include/clang/AST/APValue.h
  clang/lib/AST/APValue.cpp
  clang/lib/AST/TextNodeDumper.cpp
  clang/test/AST/ast-dump-APValue-LValue.cpp
  clang/test/AST/ast-dump-APValue-MemPtr.cpp
  clang/test/AST/ast-dump-APValue-todo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85144.285747.patch
Type: text/x-patch
Size: 8838 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200814/a0d98c1f/attachment.bin>