[PATCH] D85559: [MSAN] Reintroduce libatomic load/store instrumentation

[Evgenii Stepanov via Phabricator via cfe-commits]

eugenis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3573
+      case LibFunc_atomic_load:
+        if (!isa<CallInst>(CB)) {
+          llvm::errs() << "MSAN -- cannot instrument invoke of libatomic load."
----------------
guiand wrote:
> eugenis wrote:
> > Probably need the same check for atomic_store.
> Although it would be good for consistency I don't think it's strictly needed since with `atomic_store` we don't need to use `getNextNode()`
ah, good point. LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85559/new/

https://reviews.llvm.org/D85559