[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

[Teresa Johnson via Phabricator via cfe-commits]

tejohnson added a comment.

Thanks for the comments @vitalybuka and @davidxl, will address those shortly.

In D85948#2217476 <https://reviews.llvm.org/D85948#2217476>, @davidxl wrote:

> one nit: since the same instrumentation can be used to profiling global variable accesses (especially those indirect accessed), the option name seems excluding those cases. Shall it be renamed to fmem-prof?

Hmm, good point. Do you think all the internals (pass name, runtime names, etc) need to be renamed similarly? Or just the external facing option?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85948/new/

https://reviews.llvm.org/D85948