[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 14 11:19:59 PDT 2020


vsapsai added a comment.

Overall, looks like a reasonable approach to solve inode reuse. The problem with filenames is that they might not be canonicalized and the same file can be known by different filenames. I'm trying to think through the consequences in the following scenarios:

- same name but file content has changed;
- different names but refer to the same file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85981/new/

https://reviews.llvm.org/D85981



More information about the cfe-commits mailing list