[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 14 09:59:42 PDT 2020
MaskRay added a comment.
In D85474#2217598 <https://reviews.llvm.org/D85474#2217598>, @jhenderson wrote:
> Looks like there's only an `llc` test, but the option is in clang too? Should we have a test there?
There are generally some dotted edges in the testing of such MC level options. For options affecting IR generating, clang/test/CodeGen can do the tests. For MC level options, IR is not affected at all. Such tests belong to `llvm/test/CodeGen/`. However, clang cannot be used due to layering concerns. The closest (which is used by other options, e.g. -fuse-integrated-as, -Wa,-mrelax-relocations=) is to have some llc options similar to the clang driver options.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85474/new/
https://reviews.llvm.org/D85474
More information about the cfe-commits
mailing list