[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

Thu Aug 13 14:46:03 PDT 2020

eugenis added a comment.

In D82317#2212145 <https://reviews.llvm.org/D82317#2212145>, @jdoerfert wrote:

> In D82317#2211643 <https://reviews.llvm.org/D82317#2211643>, @guiand wrote:
>
>> After discussing with @eugenis, for the meantime it might be best to do the following:
>>
>> - Change the masking attribute to be `-fdisable-noundef-analysis` (name notwithstanding), and have it completely turn off all `noundef`s
>> - Change the llvm-lit configuration to use the new codegen flag for all the tests by default
>> - Have `noundef` emitted in the frontend by default (when the codegen flag isn't present)
>
> TBH, I don't see how this solves any problem. It just makes it a problem for someone in the future... (FWIW, I say this being in full support of `noundef`)

It solves the problem of merge conflicts in downstream forks.

This seems the best we can do given the constraints. I understand the concern that now we are not testing exactly the same mode that is normally used, but on the other hand, the majority of clang tests do not care about noundef - it's an orthogonal feature that just happens to affect their CHECK lines.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82317/new/

https://reviews.llvm.org/D82317