[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

Thu Aug 13 21:40:35 PDT 2020

NoQ added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:619
       getCheckerManager().runCheckersForEvalCall(DstEvaluated, *I, *Call, *this,
-                                                 CallOpts);
+                                                 CallOpts, Bldr);
   }
----------------
vrnithinkumar wrote:
> NoQ wrote:
> > vrnithinkumar wrote:
> > > NoQ wrote:
> > > > We should probably delete the copy-constructor for node builders. I've no idea what it's supposed to do anyway and the whole problem that we're having here is due to there being //too many// of them already.
> > > So we should disable the copying of `NodeBuilder` and create a heap allocated `NodeBuilder` and use pointer to pass around functions?
> > No-no, keep it on the stack and don't pass it around *at all*.
> Sorry, I am still little confused. 
> 
> Do we have to make the fix without passing around the `NodeBuilder`?
> And delete copy-constructor for `NodeBuilder` in this patch? 
`runCheckersForEvalCall()` already has its own builder, you don't need another.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85796/new/

https://reviews.llvm.org/D85796