[PATCH] D85810: [clang] Pass-through remarks options to lld

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 13 20:38:14 PDT 2020


MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:81
+    CmdArgs.push_back("-mllvm");
+    std::string Passes = std::string("-pass-remarks=") + A->getValue();
+    CmdArgs.push_back(Args.MakeArgString(Passes));
----------------
Delete such one-shot variables

Use Twine


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85810/new/

https://reviews.llvm.org/D85810



More information about the cfe-commits mailing list