[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

[Daniel Kiss via Phabricator via cfe-commits]

danielkiss marked an inline comment as done.
danielkiss added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:352
 
+def FeatureEmitNoteBTIProperty : SubtargetFeature<"markbtiproperty", "MarkBTIProperty",
+    "true", "Emit .note.gnu.property for Branch Target Identification" >;
----------------
chill wrote:
> No, this is an abuse of subtarget features. Subtarget features represent characteristics of the chip, they shouldn't be used to pass arbitrary bits of information.
> Possible alternatives - `TargetOptions` (cf. `BackendUtil.cpp:initTargetOptions()`) or
> LLVM command-line arguments (cf. `BackendUtil.cpp:setCommandLineOpts()`.
Thanks, now I learned how to pass flags across layers, that was not clear at the first time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81930/new/

https://reviews.llvm.org/D81930