[PATCH] D85924: [clang] Add __RELATIVE_CXX_ABI_VTABLES predefine macro

Roland McGrath via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 13 13:49:12 PDT 2020


mcgrathr added inline comments.


================
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:1127
 
+  if (LangOpts.RelativeCXXABIVTables)
+    Builder.defineMacro("__RELATIVE_CXX_ABI_VTABLES");
----------------
This should also test `LangOpts.CplusPlus` so it's never defined in C compilation.

I don't know what precedents there are to follow for how to choose the exact name here.
Having something like `__CXX_ABI_` be a prefix for all such things seems wise.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85924/new/

https://reviews.llvm.org/D85924



More information about the cfe-commits mailing list