[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChain.cpp:573
+    const char *DefaultLinker = getDefaultLinker();
+    if (!llvm::sys::path::is_absolute(DefaultLinker))
+      return GetProgramPath(DefaultLinker);
----------------
swap then and else branches to avoid `!`


================
Comment at: clang/test/Driver/solaris-ld-sld.c:6
+// FIXME: Test should be UNSUPPORTED if GNU ld isn't installed.
+// RUN: test -f /usr/gnu/bin/ld
+// RUN: env PATH=/usr/gnu/bin %clang -o %t.o %s
----------------
`!test -f /usr/gnu/bin/ld || env PATH=/usr/gnu/bin %clang %s -o /dev/null`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84029/new/

https://reviews.llvm.org/D84029