[PATCH] D85897: [SyntaxTree] Split `TreeTest.cpp`

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 13 05:53:50 PDT 2020


gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:16
+namespace clang {
+namespace syntax_test {
 namespace {
----------------
Ditto, please use namespace clang::syntax.


================
Comment at: clang/unittests/Tooling/Syntax/TreeTestBase.h:44
+namespace clang {
+namespace syntax_test {
+static ArrayRef<syntax::Token> tokens(syntax::Node *N) {
----------------
Please use the same namespace that the non-test code is using.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85897/new/

https://reviews.llvm.org/D85897



More information about the cfe-commits mailing list