[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

Thu Aug 13 05:45:41 PDT 2020

JesperAntonsson added a comment.

Hi,

In our local Jenkins machinery, the UndefOfModuleMacro test fails on master when built with gcc. Pasting the crash dump below. Any ideas?

BR  /Jesper

12:24:39 FAIL: Clangd Unit Tests :: ./ClangdTests/SymbolCollectorTest.UndefOfModuleMacro (31492 of 65755)
12:24:39 ******************** TEST 'Clangd Unit Tests :: ./ClangdTests/SymbolCollectorTest.UndefOfModuleMacro' FAILED ********************
12:24:39 Note: Google Test filter = SymbolCollectorTest.UndefOfModuleMacro
12:24:39 [==========] Running 1 test from 1 test case.
12:24:39 [----------] Global test environment set-up.
12:24:39 [----------] 1 test from SymbolCollectorTest
12:24:39 [ RUN      ] SymbolCollectorTest.UndefOfModuleMacro
12:24:39 VFS: failed to set CWD to /clangd-test: No such file or directory
12:24:39 VFS: failed to set CWD to /clangd-test: No such file or directory
12:24:39 Built preamble of size 214456 for file /clangd-test/TestTU.cpp version null
12:24:39 VFS: failed to set CWD to /clangd-test: No such file or directory
12:24:39   #0 0x00000000009e175a llvm::sys::PrintStackTrace(llvm::raw_ostream&) ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0x9e175a)
12:24:39   #1 0x00000000009df764 llvm::sys::RunSignalHandlers() ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0x9df764)
12:24:39   #2 0x00000000009df8a3 SignalHandler(int) ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0x9df8a3)
12:24:39   #3 0x00007f4051202630 __restore_rt (/lib64/libpthread.so.0+0xf630)
12:24:39   #4 0x0000000000eb291c llvm::SimpleBitstreamCursor::Read(unsigned int) ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xeb291c)
12:24:39   #5 0x000000000233a2fc llvm::SimpleBitstreamCursor::ReadVBR(unsigned int) [clone .constprop.173] ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0x233a2fc)
12:24:39   #6 0x000000000233b9f3 llvm::BitstreamCursor::readRecord(unsigned int, llvm::SmallVectorImpl<unsigned long>&, llvm::StringRef*) ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0x233b9f3)
12:24:39   #7 0x0000000001797360 clang::ASTReader::ReadSLocEntry(int)::{lambda(llvm::BitstreamCursor&, llvm::StringRef)#1}::operator()(llvm::BitstreamCursor&, llvm::StringRef) const ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0x1797360)
12:24:39   #8 0x00000000017c2511 clang::ASTReader::ReadSLocEntry(int) [clone .part.2799] ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0x17c2511)
12:24:39   #9 0x0000000000dd752d clang::SourceManager::loadSLocEntry(unsigned int, bool*) const ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xdd752d)
12:24:39  #10 0x0000000000dab66c clang::DiagnosticsEngine::DiagStateMap::lookup(clang::SourceManager&, clang::SourceLocation) const ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xdab66c)
12:24:39  #11 0x0000000000dae275 clang::DiagnosticIDs::getDiagnosticSeverity(unsigned int, clang::SourceLocation, clang::DiagnosticsEngine const&) const ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xdae275)
12:24:39  #12 0x0000000000dae725 clang::DiagnosticIDs::getDiagnosticLevel(unsigned int, clang::SourceLocation, clang::DiagnosticsEngine const&) const ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xdae725)
12:24:39  #13 0x0000000000daf181 clang::DiagnosticIDs::ProcessDiag(clang::DiagnosticsEngine&) const ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xdaf181)
12:24:39  #14 0x0000000000da50ab clang::DiagnosticsEngine::EmitCurrentDiagnostic(bool) ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xda50ab)
12:24:39  #15 0x0000000000da546c clang::DiagnosticsEngine::ReportDelayed() ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xda546c)
12:24:39  #16 0x0000000000da50cb clang::DiagnosticsEngine::EmitCurrentDiagnostic(bool) ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xda50cb)
12:24:39  #17 0x0000000000da546c clang::DiagnosticsEngine::ReportDelayed() ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xda546c)
12:24:39  #18 0x0000000000da50cb clang::DiagnosticsEngine::EmitCurrentDiagnostic(bool) ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xda50cb)
12:24:39  #19 0x0000000000da546c clang::DiagnosticsEngine::ReportDelayed() ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xda546c)
12:24:39  #20 0x0000000000da50cb clang::DiagnosticsEngine::EmitCurrentDiagnostic(bool) ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xda50cb)
12:24:39  #21 0x0000000000da546c clang::DiagnosticsEngine::ReportDelayed() ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xda546c)
[...]
12:24:39 #252 0x0000000000da50cb clang::DiagnosticsEngine::EmitCurrentDiagnostic(bool) ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xda50cb)
12:24:39 #253 0x0000000000da546c clang::DiagnosticsEngine::ReportDelayed() ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xda546c)
12:24:39 #254 0x0000000000da50cb clang::DiagnosticsEngine::EmitCurrentDiagnostic(bool) ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xda50cb)
12:24:39 #255 0x0000000000da546c clang::DiagnosticsEngine::ReportDelayed() ([...]/tools/clang/tools/extra/clangd/unittests/./ClangdTests+0xda546c)
12:24:39 
12:24:39 ********************
12:24:39 Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
12:29:50 
12:29:50 1 warning(s) in tests
12:29:50 ********************
12:29:50 Failed Tests (1):
12:29:50   Clangd Unit Tests :: ./ClangdTests/SymbolCollectorTest.UndefOfModuleMacro
12:29:50 
12:29:50 
12:29:50 Testing Time: 636.08s
12:29:50   Unsupported      :   502
12:29:50   Passed           : 65067
12:29:50   Expectedly Failed:   185
12:29:50   Failed           :     1
12:29:51 FAILED: CMakeFiles/check-all

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80525/new/

https://reviews.llvm.org/D80525