[PATCH] D85819: [SyntaxTree] Split tests

Eduardo Caldas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 13 00:57:32 PDT 2020


eduucaldas added inline comments.


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1546-1548
+unsigned operator "" _r(const char*);
+template <char...>
+unsigned operator "" _t();
----------------
eduucaldas wrote:
> Same setup for `FloatUserDefinedLiteral`. I think it is justified with the Annotations we can constraint the dump just to the expressions being tested
Taking account the Annotations change. Duplicating two lines of code between tests should be ok.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85819/new/

https://reviews.llvm.org/D85819



More information about the cfe-commits mailing list