[PATCH] D85819: [SyntaxTree] Split tests

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr2 accepted this revision.
gribozavr2 added a comment.
This revision is now accepted and ready to land.

Please also consider splitting the file into multiple.



================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1238
+namespace n {
+    template<typename T>
+    struct ST {
----------------
Indent -2.


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1412
 
-TEST_P(SyntaxTreeTest, QualifiedIdDecltype) {
+TEST_P(SyntaxTreeTest, QualifiedId_Decltype) {
   if (!GetParam().isCXX11OrLater()) {
----------------
For consistency with other test names: `QualifiedId_DecltypeSpecifier`


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2646
 
-TEST_P(SyntaxTreeTest, NestedBinaryOperator) {
+TEST_P(SyntaxTreeTest, NestedBinaryOperator_Parenthesis) {
   EXPECT_TRUE(treeDumpEqual(
----------------
BinaryOperator_NestedWithParenthesis


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2690
+
+TEST_P(SyntaxTreeTest, NestedBinaryOperator_Associativity) {
+  EXPECT_TRUE(treeDumpEqual(
----------------
BinaryOperator_Associativity


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2750
+
+TEST_P(SyntaxTreeTest, NestedBinaryOperator_Precedence) {
+  EXPECT_TRUE(treeDumpEqual(
----------------
BinaryOperator_Precedence


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2805
 
-TEST_P(SyntaxTreeTest, UserDefinedBinaryOperator) {
+TEST_P(SyntaxTreeTest, UserDefinedOperator_Assignment) {
   if (!GetParam().isCXX()) {
----------------
UserDefinedOperator => OverloadedOperator?

"user-defined" seems to suggest that the operator was previously not a thing in C++.


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:3021
+
+TEST_P(SyntaxTreeTest, UserDefinedOperator_Shift) {
+  if (!GetParam().isCXX()) {
----------------
UserDefinedOperator_LeftShift


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:3161
+
+TEST_P(SyntaxTreeTest, UserDefinedOperator_ArrowPointer) {
+  if (!GetParam().isCXX()) {
----------------
UserDefinedOperator_PointerToMember


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:3230
 
-TEST_P(SyntaxTreeTest, UserDefinedUnaryPrefixOperator) {
+TEST_P(SyntaxTreeTest, UserDefinedOperator_PrefixIncr) {
   if (!GetParam().isCXX()) {
----------------
PrefixIncrement


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:3284
+
+TEST_P(SyntaxTreeTest, UserDefinedOperator_Exclam) {
+  if (!GetParam().isCXX()) {
----------------
UserDefinedOperator_Negation


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:3393
 
-TEST_P(SyntaxTreeTest, UserDefinedUnaryPostfixOperator) {
+TEST_P(SyntaxTreeTest, UserDefinedOperator_PostfixIncr) {
   if (!GetParam().isCXX()) {
----------------
PostfixIncrement

Also, group it right after prefix increment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85819/new/

https://reviews.llvm.org/D85819